This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Improve docs somewhat. #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandburns
requested review from
davidfowl,
jkotalik and
rynowak
as code owners
|
|
loic-sharma
reviewed
Apr 24, 2020
| } | ||
| ... |
There was a problem hiding this comment.
What're your thoughts on using diff syntax?
...
public void ConfigureServices(IServiceCollection services)
{
services.AddRazorPages();
+ services.AddHttpClient<WeatherClient>(client =>
+ {
+ client.baseAddress = Configuration.GetServiceUri("backend");
+ });
}
...
There was a problem hiding this comment.
What I don't love about diff syntax is that it's not easy copy-pastable because of the + at the beginning of each line. The fencing with comments, I think makes it pretty clear.
|
Apparently this is much simpler. Getting clarification for an update |
Oops. I was testing this out while you commented and didn't see that. We can simplify this anyway now that it's merged. |
|
I'm going to add doing the tutorial(s) with linux to our release checklist since no one on the team devs with linux. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @davidfowl @jkotalik
Partially addresses #367